Skip to content

Conversation

rawlingsj
Copy link
Member

@rawlingsj rawlingsj commented Apr 18, 2023

…so it can be overridden"

We're getting failed release builds, think it's due to this change. Let's roll back to get green again and reimplement this.

This reverts commit 6e8612a.

…so it can be overridden"

We're getting failed release builds, this it's due to this change. Let's roll back to get green again and reimplement this.

This reverts commit 6e8612a.
@rawlingsj rawlingsj requested a review from a team as a code owner April 18, 2023 11:35
@rawlingsj
Copy link
Member Author

/cc @kaniini

@dlorenc
Copy link
Member

dlorenc commented Apr 18, 2023

My theory for the problem is that the change here:
image

is making it so that the directory ${sourcedir} is getting created for every package, and because it's listed as a dependency for for $(pkgtarget), it's busting the cache and triggering every package to get rebuilt (unless it already has a directory). This can be observed in the failing logs, where we attempt to build 61 packages before failing on cmake: https://pipelines.actions.githubusercontent.com/serviceHosts/969e5abc-ffab-48b3-bd54-b87797129033/_apis/pipelines/1/runs/15821/signedlogcontent/2?urlExpires=2023-04-18T11%3A00%3A03.3656729Z&urlSigningMethod=HMACV1&urlSignature=NPcXAbGBpnFvOfSLTI1lxAySHjfug2RnBsjU0%2F38BtM%3D

These builds are ordered by their order in packages.txt, but with packages that already have directories missing:

mpfr is first, when gmp is before it. Then mpc, isl, zlib, flex, but no glibc.

@rawlingsj rawlingsj added this pull request to the merge queue Apr 18, 2023
Merged via the queue into wolfi-dev:main with commit dc81a73 Apr 18, 2023
@rawlingsj rawlingsj deleted the revert branch April 18, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants