Fix for issue 9104 - Relation patch bundle check should not be done during uninstall

[JasonLow8]

Fix for issue: wixtoolset/issues#9104

This PR fixes the issue when the parent bundle is uninstalled, all related bundle is not uninstalled and orphaned. The request state is incorrect because it did not check for uninstall action.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[robmen]

Thanks. In addition to signing the CLA, please update a test that is getting this wrong, or add a test if the case is missing completely under src\test\burn\WixToolsetTest.BurnE2E. As you've found, these cases can be very subtle, and tests are how we ensure the logic is not broken.

[JasonLow8]

I have read the CLA Document and I hereby sign the CLA

[JasonLow8]

Added failing test, which succeed upon code modification.

But packageEv101 is still installed after bundleJ_patch is uninstalled, which is another bug on its own. A parent bundle is being uninstalled from the control panel, it will uninstall all bundle patch with "-burn.related.patch" parameter, before proceeding to uninstall the parent bundle. If an updated MSI is being supplied in a bundle patch, it will be left orphaned.

[JasonLow8]

Created new case for the updated MSI not uninstall bug
issue 9138

Skip the test until it is resolved.
As of current condition, Bundle Patch will be uninstalled when parent bundle is uninstalled from ARP. This will also uninstall the MSP in the bundle patch, which is my use case. Only updated MSI in the bundle patch is not uninstalled.

Consider review and merge, thanks

[robmen]

I appreciate you opening issues tracking the additional problems you found while trying to fix the issue you are interested in, however, we can't go forward without a test that verifies the change you are making. The skipped test is fine if it shows the problem described in the new issue but we need a passing test to know that your current change is working correctly.

[JasonLow8]

Added a test to verify the changes i have made. also left the test for the new issue i found.

[JasonLow8]

Hi,

Is there anything left to do for this pull request to be reviewed?