Skip to content

feat: use wire auth token for cells - WPB-18754 #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 24, 2025

Conversation

samwyndham
Copy link
Contributor

@samwyndham samwyndham commented Jul 16, 2025

Issue

This PR updates cells network clients to use the API token we use for other wire endpoints. Previously the app used fixed tokens that were input in iOS settings. Using fixed tokens is still possible if necessary via feature flag.

To achieve the above this PR:

  • Shuffles things around so that the some cells state is tied to the lifetime of a logged in user (previously these were static).
  • Ensures that AuthenticationManager is used to provide authentication tokens - the particular one used is that which belongs to the ClientSessionComponent as we shouldn't use multiple of these per logged in user due to race conditions

Testing

Wire cells functionality in the iOS client is currently very limited so the following steps are very specific.

  1. Follow steps defined here to login: https://wearezeta.atlassian.net/wiki/spaces/PAD/pages/1948680479/2025-06-12+Wire+Cells+iOS+configuration. Use imai envionment with the login credentials for sam. Remember to set the correct feature flags.
  2. Navigate to the iOS Dev 2 group
  3. Attach a file using attach icon - the file will start uploading.
  4. Once the file is uploaded tap send
  5. Confirm the message is sent - right now the message will display as just dummy text listing the file name.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@samwyndham samwyndham force-pushed the feat/wire-cells-auth-token branch from 21b064c to 10f0886 Compare July 16, 2025 08:09
Copy link
Contributor

github-actions bot commented Jul 16, 2025

Test Results

    5 files    622 suites   4m 16s ⏱️
3 878 tests 3 851 ✅ 27 💤 0 ❌
3 890 runs  3 863 ✅ 27 💤 0 ❌

Results for commit 68ccc8b.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jul 16, 2025

Datadog Report

Branch report: feat/wire-cells-auth-token
Commit report: aa20cb8
Test service: wire-ios-mono

✅ 0 Failed, 4160 Passed, 27 Skipped, 1m 55.61s Total Time

@samwyndham samwyndham requested review from a team, netbe, KaterinaWire and jullianm and removed request for a team, netbe and KaterinaWire July 16, 2025 10:42
@samwyndham samwyndham requested a review from caldrian July 17, 2025 11:53
Copy link
Contributor

@caldrian caldrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, what confuses me though is that some logic seems to be related to "networking" logic (AWSClient, NodesAPI, RestAPI) yet still live in WireCells. Shouldn't it be moved to WireNetwork ?

@samwyndham samwyndham added this pull request to the merge queue Jul 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025
@samwyndham samwyndham added this pull request to the merge queue Jul 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025
@samwyndham samwyndham enabled auto-merge July 22, 2025 15:05
@samwyndham samwyndham added this pull request to the merge queue Jul 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025
@samwyndham samwyndham added this pull request to the merge queue Jul 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025
@samwyndham samwyndham added this pull request to the merge queue Jul 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025
@samwyndham samwyndham added this pull request to the merge queue Jul 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2025
# Conflicts:
#	wire-ios/Wire-iOS/Sources/UserInterface/MainController/ZClientViewController.swift
@samwyndham samwyndham enabled auto-merge July 24, 2025 12:07
@samwyndham samwyndham added this pull request to the merge queue Jul 24, 2025
Merged via the queue into develop with commit ee55c66 Jul 24, 2025
12 checks passed
@samwyndham samwyndham deleted the feat/wire-cells-auth-token branch July 24, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants