-
Notifications
You must be signed in to change notification settings - Fork 21
feat: use wire auth token for cells - WPB-18754 #3344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WireNetwork/Sources/WireNetwork/Authentication/AuthenticationManager.swift
Outdated
Show resolved
Hide resolved
wire-ios/Wire-iOS Tests/Mocks/WireCells/WireCellsClearPublishedDraftsUseCaseProtocolMock.swift
Show resolved
Hide resolved
21b064c
to
10f0886
Compare
Test Results 5 files 622 suites 4m 16s ⏱️ Results for commit 68ccc8b. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 4160 Passed, 27 Skipped, 1m 55.61s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, what confuses me though is that some logic seems to be related to "networking" logic (AWSClient, NodesAPI, RestAPI) yet still live in WireCells. Shouldn't it be moved to WireNetwork ?
Issue
This PR updates cells network clients to use the API token we use for other wire endpoints. Previously the app used fixed tokens that were input in iOS settings. Using fixed tokens is still possible if necessary via feature flag.
To achieve the above this PR:
AuthenticationManager
is used to provide authentication tokens - the particular one used is that which belongs to theClientSessionComponent
as we shouldn't use multiple of these per logged in user due to race conditionsTesting
Wire cells functionality in the iOS client is currently very limited so the following steps are very specific.
imai
envionment with the login credentials forsam
. Remember to set the correct feature flags.iOS Dev 2
groupChecklist
[WPB-XXX]
.