feat: Handle mls-reset event - WPB-18664 #3331
Merged
+470
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrysimkin
changed the title
netbe
changed the title
…p/wire-ios into feature/mls-reset-event-WPB-18664
Test Results 9 files 750 suites 9m 33s ⏱️ For more details on these failures, see this check. Results for commit e7115ce. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 5151 Passed, 27 Skipped, 2m 7.5s Total Time |
dmitrysimkin
commented
Jul 16, 2025
...eDomain/Event Processing/ConversationEventProcessor/ConversationMLSResetEventProcessor.swift
Show resolved
Hide resolved
netbe
approved these changes
Jul 16, 2025
...rces/WireDomain/Event Processing/ConversationEventProcessor/ConversationEventProcessor.swift
Outdated
Show resolved
Hide resolved
...eDomain/Event Processing/ConversationEventProcessor/ConversationMLSResetEventProcessor.swift
Show resolved
Hide resolved
WireDomain/WireDomain Project.xcodeproj/xcshareddata/xcschemes/WireDomainProject.xcscheme
Outdated
Show resolved
Hide resolved
...work/APIs/UpdateEventsAPI/Event decoding/Conversation/ConversationMLSResetEventDecoder.swift
Show resolved
Hide resolved
.../WireNetwork/APIs/UpdateEventsAPI/Event decoding/UpdateEventDecodingProxy+Conversation.swift
Show resolved
Hide resolved
KaterinaWire
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Handle when we receive event to reset broken MLS component, by wiping group and update it with new groupID