feat: add new conversation filters - WPB-18707

[emil-wire]

WPB-18707 [iOS] add filter for unread messages, mentions and replies

Issue

This is my attempt at adding some additional filters to the app. I've tried to stick to the general implementation of the other filter items that already exist. The filters cover unread, mentions and replies. They're hidden behind a feature flag because the design isn't finalized yet. Since this is my first contribution, I'd appreciate all the feedback I can get, especially what tests I should write.

Testing

Open the app, tap the conversation filters and give it a spin

---

Checklist

• Title contains a reference JIRA issue number like [WPB-XXX].
• Description is filled and free of optional paragraphs.
• Adds/updates automated tests.

---

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

• Make sure you use the API for UI elements that support large fonts.
• All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
• New UI elements have Accessibility strings for VoiceOver.

[github-actions]

Test Results

4 647 tests   4 619 ✅  7m 29s ⏱️
  629 suites     28 💤
    4 files        0 ❌

Results for commit a39f00c.

♻️ This comment has been updated with latest results.

[datadog-wireapp]

Datadog Report

Branch report: feat/add-filter-for-unread-messages-WPB-18707
Commit report: 5ad3b5f
Test service: wire-ios-mono

✅ 0 Failed, 4664 Passed, 28 Skipped, 3m 50.48s Total Time

[netbe]

Thanks for the contribution @emil-wire, it will be definitely useful!

2 things:

• I have to kill the app for the flag to take effect
• I am surprised the filter is not applied at the SyncEngine level. We usually add the predicates in ZMConversationListDirectory.

• would be cool to add the draft as well

[emil-wire]

@netbe I added drafts, moved the predicates to the right place and hopefully fixed the flag.
Regarding the tests, could you give me some guidance? Really not sure what to test, how to test. I'm using this as an exercise to learn more about our app and try to understand how it works - so please teach me master :)

[samwyndham]

Great work! Thank you for contributing! Before merging I think we should either:

• remove the observation of the developer flag
• find a way to make it more granular (I expect KVO) on the UserDefaults object

[netbe]

looks good, just fix the remained comments tests fixed.

The UI snapshots need to be recorded too with:
IOS_VERSION='18.0'
IPHONE_MODEL='iPhone 14'

[emil-wire]

@netbe @samwyndham I've used KVO instead as suggested and fixed up the tests. Added some snapshots using the correct device/os combo too

Removed the performance test

[samwyndham]

Great work! I'm excited to use this!