Skip to content

Conversation

dmitrysimkin
Copy link
Contributor

@dmitrysimkin dmitrysimkin commented Apr 23, 2025

BugWPB-17195 [iOS] Incorrect guest and services settings after creating a group

Issue

Fix passing config values for channel creation

Testing

Pass allow guests on and off and check in conversation details


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@dmitrysimkin dmitrysimkin requested review from a team, samwyndham, caldrian and KaterinaWire and removed request for a team April 23, 2025 11:01
@dmitrysimkin dmitrysimkin requested a review from jullianm April 23, 2025 11:02
Copy link
Contributor

github-actions bot commented Apr 23, 2025

Test Results

    2 files    290 suites   2m 44s ⏱️
1 807 tests 1 780 ✅ 27 💤 0 ❌
1 817 runs  1 790 ✅ 27 💤 0 ❌

Results for commit a6a751a.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/passing-values-for-channel-creation-to-release
Commit report: 998d8ab
Test service: wire-ios-mono

✅ 0 Failed, 1790 Passed, 27 Skipped, 2m 2.92s Total Time

@dmitrysimkin dmitrysimkin enabled auto-merge (squash) April 24, 2025 10:14
@dmitrysimkin dmitrysimkin merged commit f26c4b3 into release/cycle-3.123 Apr 24, 2025
8 checks passed
@dmitrysimkin dmitrysimkin deleted the fix/passing-values-for-channel-creation-to-release branch April 24, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants