chore: remove voip handling - WPB-17290 #2916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netbe
commented
Apr 18, 2025
netbe
commented
Apr 18, 2025
netbe
commented
Apr 18, 2025
netbe
commented
Apr 18, 2025
netbe
commented
Apr 18, 2025
netbe
requested review from
a team,
dmitrysimkin,
El-Fitz and
KaterinaWire
and removed request for
a team
Test Results 7 files 983 suites 8m 47s ⏱️ Results for commit eb02412. ♻️ This comment has been updated with latest results. |
dmitrysimkin
approved these changes
Apr 22, 2025
samwyndham
approved these changes
May 2, 2025
...uest-strategy/Sources/Request Strategies/Push Token/Actions/GetPushTokensActionHandler.swift
Outdated
Show resolved
Hide resolved
KaterinaWire
approved these changes
May 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3 tasks
This was referenced May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We don't use VOIP push anymore since iOS 15. Still we have some code that handles it. This PR cleans up what's not used.
Testing
N/A