Skip to content

chore: a few preparations before integrating multi-platform lib - WPB-14598 #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Apr 14, 2025
Merged

chore: a few preparations before integrating multi-platform lib - WPB-14598 #2873

merged 26 commits into from
Apr 14, 2025

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Apr 10, 2025 •
edited by github-actions bot
Loading

TaskWPB-14598 [iOS] Add shared backup library as a dependency

Issue

This PR

  • renames the current sourcery stencil "AutoMockable" -> "LegacyAutoMockable"
  • adds an updated stenicl
  • renames target "WireDomainPkg" to "WireDomainPackage"
  • updates the WireDomain package to Swift 6
  • prevents a build error with Xcode 16.3

Testing

Automatic tests should pass.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian requested review from samwyndham and jullianm April 10, 2025 11:01
@caldrian caldrian changed the title chore: few preparations before integrating multi-platform lib - WPB-14598 chore: few preparations before integrating multi-platform lib - WPB-14598 Apr 10, 2025
@caldrian caldrian changed the title chore: few preparations before integrating multi-platform lib - WPB-14598 chore: few preparations before integrating multi-platform lib - WPB-14598 Apr 10, 2025
caldrian
caldrian commented Apr 10, 2025
View reviewed changes
caldrian
caldrian commented Apr 10, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025 •
edited
Loading

Test Results

   15 files  1 087 suites   9m 42s ⏱️
7 930 tests 7 899 ✅ 31 💤 0 ❌
7 971 runs  7 940 ✅ 31 💤 0 ❌

Results for commit 2eb60d8.

♻️ This comment has been updated with latest results.

@caldrian caldrian enabled auto-merge April 10, 2025 12:20
@wireapp wireapp deleted a comment from datadog-wireapp bot Apr 10, 2025
samwyndham
samwyndham approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

netbe
netbe reviewed Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple questions before approving

@caldrian caldrian changed the base branch from develop to release/cycle-3.122 April 14, 2025 07:28
@caldrian caldrian changed the title chore: few preparations before integrating multi-platform lib - WPB-14598 chore: a few preparations before integrating multi-platform lib - WPB-14598 Apr 14, 2025
@caldrian caldrian requested a review from netbe April 14, 2025 10:09
netbe
netbe approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge

@caldrian caldrian removed the request for review from jullianm April 14, 2025 10:31
jullianm
jullianm approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

auto-merge was automatically disabled April 14, 2025 10:53

Merge commits are not allowed on this repository

@caldrian caldrian merged commit 80e06b8 into release/cycle-3.122 Apr 14, 2025
22 checks passed
@caldrian caldrian deleted the chore/preparations-maintenance-WPB-14598 branch April 14, 2025 10:53
zenkins pushed a commit that referenced this pull request Apr 14, 2025
@caldrian @github-actions
chore: a few preparations before integrating multi-platform lib - WPB…
395163e 
…-14598 (#2873)
@github-actions github-actions bot mentioned this pull request Apr 14, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netbe netbe netbe approved these changes

@samwyndham samwyndham samwyndham approved these changes

@jullianm jullianm jullianm approved these changes

Assignees

@caldrian caldrian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caldrian @netbe @samwyndham @jullianm