Skip to content

fix: add recent reaction to map as a visual aid when animations are disabled (WPB-18128) #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 21, 2025

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jul 17, 2025

TaskWPB-18128 [Android]In-call reaction not flowing across the screen for the sender


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When animations are disabled, there is no visual indication of the emoji animation sent.

Causes (Optional)

Can happen when disabled by developer options or a11y settings.

Solutions

Add the sent reaction to recentReactions map, so it will be displayed in the self user tile.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Disable animations (or not) the reaction sent, should be displayed in the self user tile.

Attachments (Optional)

Screen.Recording.2025-07-17.at.14.56.11.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
bbf3c87c6319309441466844df96f2463310c5db 67f12712e13c0eed197a6322ce144d39cc88445e

Is this intentional?

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.81%. Comparing base (bff5951) to head (bb9b073).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4123   +/-   ##
========================================
  Coverage    47.80%   47.81%           
========================================
  Files          507      507           
  Lines        17437    17439    +2     
  Branches      2868     2868           
========================================
+ Hits          8336     8338    +2     
  Misses        8245     8245           
  Partials       856      856           
Files with missing lines Coverage Δ
.../wire/android/ui/calling/SharedCallingViewModel.kt 68.78% <100.00%> (+0.40%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff5951...bb9b073. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Built wire-android-staging-compat-pr-4123.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4123.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-4123.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4123.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-4123.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4123.apk is available for download

@yamilmedina yamilmedina force-pushed the yamil/feat/self-recentemoji branch from c2c4148 to cd4a0d9 Compare July 18, 2025 11:54
@yamilmedina yamilmedina requested review from a team, typfel, vitorhugods and Garzas and removed request for a team and typfel July 18, 2025 11:57
@yamilmedina yamilmedina requested a review from saleniuk July 18, 2025 11:57
@yamilmedina yamilmedina enabled auto-merge July 18, 2025 13:01
Copy link

@yamilmedina yamilmedina added this pull request to the merge queue Jul 21, 2025
Merged via the queue into develop with commit bc842a4 Jul 21, 2025
9 of 12 checks passed
@yamilmedina yamilmedina deleted the yamil/feat/self-recentemoji branch July 21, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants