-
Notifications
You must be signed in to change notification settings - Fork 39
fix: add recent reaction to map as a visual aid when animations are disabled (WPB-18128) #4123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@yamilmedina looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4123 +/- ##
========================================
Coverage 47.80% 47.81%
========================================
Files 507 507
Lines 17437 17439 +2
Branches 2868 2868
========================================
+ Hits 8336 8338 +2
Misses 8245 8245
Partials 856 856
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Built wire-android-staging-compat-pr-4123.apk is available for download |
Built wire-android-dev-debug-pr-4123.apk is available for download |
Built wire-android-staging-compat-pr-4123.apk is available for download |
Built wire-android-dev-debug-pr-4123.apk is available for download |
Built wire-android-staging-compat-pr-4123.apk is available for download |
Built wire-android-dev-debug-pr-4123.apk is available for download |
c2c4148
to
cd4a0d9
Compare
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When animations are disabled, there is no visual indication of the emoji animation sent.
Causes (Optional)
Can happen when disabled by developer options or a11y settings.
Solutions
Add the sent reaction to
recentReactions
map, so it will be displayed in the self user tile.Testing
Test Coverage (Optional)
How to Test
Disable animations (or not) the reaction sent, should be displayed in the self user tile.
Attachments (Optional)
Screen.Recording.2025-07-17.at.14.56.11.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.