feat: do not allow renaming file with extension (WPB-18314) #4114
+28
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohassine
changed the title
|
yamilmedina
approved these changes
Jul 15, 2025
| @@ -91,7 +91,7 @@ fun RenameNodeScreen( | |||
| ) { | |||
| WirePrimaryButton( | |||
| text = stringResource(R.string.rename_label), | |||
| onClick = { renameNodeViewModel.renameNode() }, | |||
| onClick = { renameNodeViewModel.renameNode(renameNodeViewModel.textState.text.toString()) }, | |||
There was a problem hiding this comment.
Question: Why do we need to pass the reference ? Since we could just access it from within the viewmodel, like it was before ? 🤔
Garzas
reviewed
Jul 23, 2025
|
|
||
| advanceUntilIdle() | ||
| viewModel.actions.test { | ||
| with(expectMostRecentItem()) { | ||
| assertEquals(false, viewModel.displayNameState.loading) | ||
| assertEquals(DisplayNameState.Completed.Success, viewModel.displayNameState.completed) | ||
| assertTrue(this is RenameNodeViewModelAction.Success) | ||
| coVerify(exactly = 1) { arrangement.renameNodeUseCase(eq(UUID), eq(CURRENT_PATH), eq("newFileName.txt")) } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| fun `given renameNodeUseCase failure, when rename is called, then send failure action`() = runTest { |
There was a problem hiding this comment.
Can we also have test for InvalidNameError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.