-
Notifications
You must be signed in to change notification settings - Fork 9
ci: create xcode simulators when running tests #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eecdf27
to
eff35c0
Compare
eff35c0
to
2733eb6
Compare
2733eb6
to
99da20b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, but we need to avoid creating multiple devices for the interop test and move device creation/removal to standalone scripts.
4a87e94
to
d89522c
Compare
We used to create a device for building the App used in the test and another device to actually run the test. We can do both with the same simulator device. Note that a device deletion will shutdown the device if it is booted. Thus, we remove the manual shutdown of the device.
d89522c
to
5fb5bb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
What's new in this PR
With this PR ios tests with device specific xcode build destinations create a dedicated device for test first and remove it after finishing the test. This should avoid any CI errors related to non existent simulator devices when using xcodebuild.
PR Submission Checklist for internal contributors
SQPIT-764
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.