Utilizing async 2.6.4 for node 4 compatibility #2166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will there be a published version of 2.4.7? for example i only see up to 2.4.6 at https://www.npmjs.com/package/winston. |
Contributor
|
@lexinator done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good afternoon Winston developers,
This PR is to restore node 4 compatibility while maintain the CVE fix linked here: https://security.snyk.io/vuln/SNYK-JS-ASYNC-2441827
This is in regards to this issue: #2130
I attempted to update the testing, but the 2.X branch does not have the CI/CD workflow. So I tested it manually and it passed.
Please let me know if you have any questions.