Revert "fix: handle undefined rejections" #2016
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2299d19.
Contributor
Author
|
This discussion seems like it might be relevant. |
Contributor
|
Hmm, though if I just run the mocha command (which should ignore all eslint stuff), I can still see the test fail... |
Contributor
Author
|
Yeah, now that I am reading more context on that I don't think there's much in common with the issues there were getting around unhandled rejections between the time of the PR reporting that checks passed and the time of the merge. This might not be the culprit. |
Contributor
|
Agreed, since I can repro this test error locally on commits even before we merged that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking impact of reverting #1961 on tests