[Bug]: ERR_REQUIRE_ESM with winston@3.18.0

[ddolcimascolo]

🔎 Search Terms

require esm breaking change

The problem

Hello,

I suppose this breaking change wasn't intended and is a consequence of the bump of the diagnostics package...

Cheers,
David

What version of Winston presents the issue?

v3.18.0

What version of Node are you using?

v22.11.0

If this worked in a previous version of Winston, which was it?

v3.17.x

Minimum Working Example

Just require('winston') in a commonjs module.

Additional information

Exception during run: Error [ERR_REQUIRE_ESM]: require() of ES Module /builds/stordata/spoolx/node_modules/@so-ric/colorspace/index.js from /builds/stordata/spoolx/node_modules/@dabh/diagnostics/modifiers/namespace-ansi.js not supported.
Instead change the require of index.js in /builds/stordata/spoolx/node_modules/@dabh/diagnostics/modifiers/namespace-ansi.js to a dynamic import() which is available in all CommonJS modules.

[DABH]

Hi @ddolcimascolo, thanks for the heads up about this issue. If you have a minimal example I could copy paste to verify things here (or even perhaps a test to contribute to winston!), that would help. I will try to see what's up here and if there is a quick fix.

[talatkuyuk]

It throws error also in jest environment (with --experimental-vm-modules)

Must use import to load ES Module: /Users/talatkuyuk/MyCodeRepo/nodejsprojects/nodejs-express-jwt-mongodb-boilerplate/node_modules/@so-ric/colorspace/index.js

    > 1 | const winston = require("winston");

[ddolcimascolo]

Hi @ddolcimascolo, thanks for the heads up about this issue. If you have a minimal example I could copy paste to verify things here (or even perhaps a test to contribute to winston!), that would help. I will try to see what's up here and if there is a quick fix.

I can surely provide it, but really it's just require('winston') 😅

[DABH]

Hi @ddolcimascolo @talatkuyuk , can you please try v3.18.1 and confirm whether this is resolved or not?

[DABH]

👀

[dilipkhemani]

Yes this version fixed the issue. Thanks

[DABH]

Great, thanks for confirming! 🤝

[talatkuyuk]

My issue continues with 3.18.1 in jest environment. (note: 3.17.0 works fine)
My project is commonjs FYI.

● Test suite failed to run

    Must use import to load ES Module: /Users/talatkuyuk/MyCodeRepo/nodejsprojects/nodejs-express-jwt-mongodb-boilerplate/node_modules/@so-ric/colorspace/index.js

    > 1 | const winston = require("winston");
        |                 ^
      2 |
      3 | const config = require("../config");
      4 |

      at Runtime.requireModule (node_modules/jest-runtime/build/index.js:801:21)
      at Object.require (node_modules/fix-esm/index.js:48:18)
      at Object.<anonymous> (node_modules/@dabh/diagnostics/modifiers/namespace-ansi.js:2:25)
      at Object.<anonymous> (node_modules/@dabh/diagnostics/node/development.js:29:20)
      at Object.<anonymous> (node_modules/@dabh/diagnostics/node/index.js:7:20)
      at Object.<anonymous> (node_modules/winston/lib/winston/exception-handler.js:12:15)
      at Object.<anonymous> (node_modules/winston/lib/winston/logger.js:14:26)
      at Object.<anonymous> (node_modules/winston/lib/winston/create-logger.js:12:16)
      at Object.<anonymous> (node_modules/winston/lib/winston.js:42:24)
      at Object.<anonymous> (src/core/logger.js:1:17)
      at Object.<anonymous> (src/services/redis.service.js:4:16)
      at Object.<anonymous> (src/services/auth.service.js:12:22)
      at Object.<anonymous> (src/services/index.js:1:30)
      at Object.<anonymous> (src/middlewares/authenticate.js:9:26)
      at Object.<anonymous> (src/middlewares/index.js:1:31)
      at Object.<anonymous> (tests/unit/middleware.validate.auth.test.js:3:22)

[DABH]

Ok, taking a look to see what can be done here - stand by...