Winston 3 #63
Open
Winston 3 #63
+722
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds new params stripColors and timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to adapt the project to winston-3 due to the various breakchanges between the old and new library versions.
I took the opportunity and rewrote the code in typescript taking advantage of the typing and compilation. I also include the mocha / chai for testing and write more tests cases.
I have published in a scoping npm record to execute tests in my projects. But the idea is to contribute to the project and not create one more fork of it.
There is something to do before a clean release:
implements stream (it isn`t in winston-3 but avoid breaks)
change README to new fashion use of winston-3
write some query tests