-
Notifications
You must be signed in to change notification settings - Fork 110
Add support for host #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👍 |
|
👍 |
|
👍 Yeah, this would be great to have! |
|
@indexzero anything stopping merging this PR in? |
|
👍 |
|
Hey all, I was tripped up by the README on this. The Setting it to The default is I would suggest reverting this, as it is breaks the transport silently. At a minimum, I can submit a PR to correct the README. |
More info: winstonjs#30 (comment)
|
@bradfol thanks for finding this. An update to tests with a subsequent PR would be very helpful. |
|
@bradfol @indexzero I misunderstood the purpose of host. Thanks for caching this. I would suggest undoing my PR, as there is not really a good reason to configure this. Apologies for troubles caused. |
|
@indexzero @chris-rudmin Thanks guys. I've opened PR #35 to revert this. |
Revert "Merge pull request #30 from chris-rudmin/master"
Error message support in winston-loggly-bulk
No description provided.