Allow setting tags per log statement

[mattcasey]

In the original code, "meta.tags" never gets used because this.tags is always set.

[jcrugzz]

@mattcasey curious as to what makes this.tags always defined. is it options.id? wondering if ensuring it defaults to an array and concatting the tags. As you may want to set global ones AND tags per message. Thoughts?

[indexzero]

@jcrugzz yes. Exactly: https://github.com/winstonjs/winston-loggly/blob/master/lib/winston-loggly.js#L40

[indexzero]

lgtm.

[jcrugzz]

@indexzero i still think we may want to concat in this case rather than override.

[indexzero]

mmm ... idk. Semantically I could see how that would bother me.

[indexzero]

e.g. "I only want to send THESE tags, nothing else!"

[jcrugzz]

@indexzero eh i guess my thought there is that IF you were to define global tags, i may want to add custom tags inheriting those global ones for different type of log messages. But since it defaults to the ID i could see it being less of an expectation.

[jcrugzz]

but im biased as this is how i made the node-loggly client work internally since you only explicitly provide global tags as well as per Log message tags

[indexzero]

yeah, it's also likely you keep them in the outer scope when you pass them into the Loggly transport instance. e.g.:

var winston = require('winston'),
    Loggly = require('winston-loggly');

var tags = ['this', 'that', 'the-other'];

var logger = new winston.Logger({
  transports: [
    new Loggly({ tags: tags })
  ]
});

logger.info('hey, a log!', { 
  tags: tags.concat(['custom-tags', 'over-here', 'with-default-tags-too'])
});

[jcrugzz]

@indexzero well i do believe we may have differing assumptions as this still feels weird to me. Since the pull-request was for this way, we can leave it at that ;).

[indexzero]

@jcrugzz I didn't know that about the node-loggly client. I must've missed it in the v2.0 refactor. Is this what you have in mind? #24

[mattcasey]

Hey guys! Thanks for accepting our PR. It didn't cross my mind to allow inheriting the tags. I could live with either way, just so long as we can add specific tags along-side each message :)