Skip to content

Handle loggly errors #3

@naholyr

Description

@naholyr

Currently, there is absolutely no error handling:

    this.client.log(this.inputToken, message, function () {
      self.emit('logged');
      callback(null, true);
    });

Today I face (not sure if it's usual with Loggly, I use it only very recently) a lot of "Error: socket hang up" errors. At least half of my events are not sent, and there is no way I can know it from the transport :(

You could change this part to something like this so we can plug to "error" event:

    this.client.log(this.inputToken, message, function (err) {
      self.emit(err ? 'error' : 'logged', err);
      callback(err, !!err);
    });

Or at least pass err to callback so we can catch it and re-call log().

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions