Remove support for Ruby 3.1 and aligned JRuby 9.4. Add support for JRuby 10. #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The JRuby failures make me think that in practice this PR needs to land on top of #508. |
faisal
force-pushed
the
ruby_3_1_eol
branch
2 times, most recently
from
e290fa9 to
1a16b19
Compare
faisal
force-pushed
the
ruby_3_1_eol
branch
2 times, most recently
from
e5a99e2 to
150583b
Compare
This was referenced Jun 1, 2025
|
|
faisal
changed the title
|
Note that this includes some of the JRuby support fixes from #508. |
|
This could probably use more review than "we finally got CI to pass." |
…r JRuby 10 - rubycritic.gemspec: update minimum Ruby version to 3.2 - .rubocop.yml: update target Ruby version to 3.2 - CI: drop Ruby 3.1, and change jruby from 9.4 (Ruby 3.1) to jruby to 10 (Ruby 3.4) - add platform value to the gemspec, and require jar-dependencies version # Conflicts: # CHANGELOG.md
|
This patch only differs from the prior attempt in that the CHANGELOG was updated. This failure is the same failure as from two runs ago. I do not see it on my machine. I could use help investigating. |
|
I can now intermittently reproduce this failure locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://endoflife.date/ruby, Ruby 3.1 is EOL. This PR prepares for when we want to drop support.
Note: this PR changes the JRuby CI tests from 9.4 (Ruby 3.1) to HEAD (Ruby 3.4, still in testing), because there isn't a post-9.4 stable JRuby with a newer Ruby version. I expect we'll want to change the CI again once one is available.
continue-on-errorCheck list: