Error when calling pthread_cond_signal() function

[edbek]

Inside pthread_cond_signal() is called each time mtx_init().
mtx_init() is created the semaphore in any case:

mutex->sem = xSemaphoreCreateBinary ();

This condition should be avoided:

if ( !mutex-> sem ) mutex->sem = xSemaphoreCreateBinary ();

In addition, all of the objects by malloc () must be reset. Used calloc () or memcpy(0) after malloc().

[jolivepetrus]

In pthread programming first you have to initialise the variables in the pthread style, using the initializer for that variable. For conditions, you must do:

pthread_cond_t cond = PTHREAD_COND_INITIALIZER;

Once variable is initialise you can use it in pthread functions. If you do this somewhere in your code prior to call pthread_cond_signal the mutext will be created once.

[edbek]

Ok.

But then you have to alter pthread_cond_init() function.
There is a situation when cond->mutex.sem ! = NULL, and then pthread_cond_init() function does nothing, and it should release the semaphore.
For example, the function introduction (where inside there pthread_cond_init)

pthread_cond_wait()
pthread_cond_timedwait()
pthread_cond_signal()

can not release the semaphore !

[jolivepetrus]

Let me to make a review ....

[jolivepetrus]

Please, take a look at:

22d4b1d

[jolivepetrus]

Let me to close this issue. No feedback were provided.