Skip to content

Spec the prefixed CSS Animation/Transition event handlers #5188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 9, 2020
Merged

Spec the prefixed CSS Animation/Transition event handlers #5188

merged 7 commits into from
Jan 9, 2020

Conversation

stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Jan 3, 2020

See whatwg/compat#118

Tests: web-platform-tests/wpt#19099 (will need moved from compat to appropriate parts of the html spec).


/webappapis.html ( diff )

@stephenmcgruer
Copy link
Contributor Author

@domenic @annevk PTAL. Reminder: we had previous conversations in whatwg/compat#119 :)

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normative content seems good, just some editorial stuff...

@stephenmcgruer stephenmcgruer requested a review from domenic January 7, 2020 19:59
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Will leave for a bit in case @annevk wants to take a look; otherwise will merge tomorrow.

@domenic domenic added addition/proposal New features or enhancements topic: events labels Jan 8, 2020
@domenic domenic merged commit 0b8e268 into whatwg:master Jan 9, 2020
@domenic
Copy link
Member

domenic commented Jan 9, 2020

Note that via the IDL sync this will automatically generate tests for GlobalEventHandlers in https://github.com/web-platform-tests/wpt/blob/master/html/webappapis/scripting/events/event-handler-all-global-events.html.

@stephenmcgruer can you comment back on this issue with the bug URLs for each browser?

@stephenmcgruer
Copy link
Contributor Author

@domenic Sorry, what bug URLs are you referring to?

@annevk
Copy link
Member

annevk commented Jan 10, 2020

@stephenmcgruer bugs you filed against browsers, such as https://bugzilla.mozilla.org/show_bug.cgi?id=1607918 against Firefox. We typically list those in specification PRs for people doing spelunking.

@stephenmcgruer
Copy link
Contributor Author

Ack. Here are the related bugs from this spec PR change:

Chrome:

Firefox:

Safari:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements topic: events
Development

Successfully merging this pull request may close these issues.

3 participants