Update HTTPFetch algorithm to support new SW Handle Fetch returns #1832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will update the HttpFetch algorithm, particularly the handling of the response for Service Worker fetch (`handle fetch` step). Currently, the response of handle fetch step is assumed to return the `response` type (or null, if the ServiceWorker couldn't handle the fetch and need to fallback to the network request). However, we have changed the `handle fetch` step to also return `service worker timing info` when the ServiceWorker static routing API used, so that the corresponding timing information are correctly exposed when the ServiceWorker could not handle the fetch. To support this new return type, we need to update the handling of the response of `handle fetch`. To expose the Service Worker Timing Info to the resource timing API, we also associate them to the Fetch Timing Info so that it could be later referenced.
|
This PR is for the resource timing API changes of ServiceWorker static routing API. Since some of the criterias are not met yet, let me make this as draft. |
This was referenced May 30, 2025
|
Let me make this a PR and ask for opinions about this. |
|
@yoshisatoyanagisawa Could you check if this make sense? Thanks! |
| <var>serviceWorkerStartTime</var>. | ||
| <li><p>Set <var>fetchParams</var>'s <a for="fetch params">timing info</a>'s | ||
| <a for="fetch timing info">service worker timing info</a> to | ||
| <var>response</var>'s <a for="response">service worker timing info</a>. |
There was a problem hiding this comment.
"2.2.6. Responses" should be updated to have associated service worker timing info?
| <li><p>Set <var>fetchParams</var>'s <a for="fetch params">timing info</a>'s | ||
| <a for="fetch timing info">final service worker start time</a> to | ||
| <var>serviceWorkerStartTime</var>. | ||
| <li><p>Set <var>fetchParams</var>'s <a for="fetch params">timing info</a>'s |
There was a problem hiding this comment.
It is not a blocker but resource-timing may not not have a trivial way to know response, right? I just wondered why we need to copy the timing info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will update the HttpFetch algorithm, particularly the handling of the response for Service Worker fetch (
handle fetchstep). Currently, the response of handle fetch step is assumed to return theresponsetype (or null, if the ServiceWorker couldn't handle the fetch and need to fallback to the network request). However, we have changed thehandle fetchstep to also returnservice worker timing infowhen the ServiceWorker static routing API used, so that the corresponding timing information are correctly exposed when the ServiceWorker could not handle the fetch. To support this new return type, we need to update the handling of the response ofhandle fetch.To expose the Service Worker Timing Info to the resource timing API, we also associate them to the Fetch Timing Info so that it could be later referenced.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff