Added driver parameter to get_connection_string and get_engine methods #37
+9
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy Python projects which use psycopg2 driver cannot currently use py-pglite, because the
library does not support parametrizing the sqlalchemy connection string with driver name.
This PR fixes this issue by allowing a driver name argument to be specified when calling the
get_connection_stringmethod of thePGliteConfigclass and when calling theget_enginemethod of the
SQLAlchemyPGliteManagerclass.The default value of this parameter is "psycopg", so this change is compatible with all existing
usages of this library and does not break any implementations. Please consider merging this PR and
releasing a new minor version, as my work on a legacy Python project depends on this change.
Here's some context of what I'm currently doing:
Instead of using MonkeyPatch to achieve the desired result, this PR would enable to use the following elegant solution: