Build: Let wet-boew dependency use npm >=10.7.0#2729
Merged
Garneauma merged 1 commit intowet-boew:masterfrom Feb 4, 2026
Merged
Build: Let wet-boew dependency use npm >=10.7.0#2729Garneauma merged 1 commit intowet-boew:masterfrom
Garneauma merged 1 commit intowet-boew:masterfrom
Conversation
wet-boew/wet-boew#9924 previously changed it from ^10.7.0 to >=10.7.0, but GCWeb's package-lock.json file wasn't updated to match (was still set to ^10.7.0). In practice, this change prevents "EBADENGINE Unsupported engine" warnings when running npm install in GCWeb via npm 11 (like in node.js 24.x)... and possibly beyond.
EricDunsworth
temporarily deployed
to
github-ci
GitHub Actions
Inactive
Garneauma
approved these changes
Feb 4, 2026
Collaborator
|
@BeraJosh For your review. |
BeraJosh
approved these changes
Feb 4, 2026
BeraJosh
left a comment
BeraJosh
left a comment
There was a problem hiding this comment.
No CVE/issues in the npm 10.7.0 module.
Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wet-boew/wet-boew#9924 previously changed it from ^10.7.0 to >=10.7.0, but GCWeb's package-lock.json file wasn't updated to match (was still set to ^10.7.0).
In practice, this change prevents "EBADENGINE Unsupported engine" warnings when running
npm installin GCWeb via npm 11 (like in node.js 24.x)... and possibly beyond.CC @nschonni @Garneauma