fix scroll bug #6125
Merged
fix scroll bug #6125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think I've found the culprit #5809. The preview site works just fine before this pull request. |
|
Interesting. Not sure how dev-server is related here since it is a dev dependency. |
|
This is more like an issue existing for a long time according to remix-run/react-router#394, obviously we were not handling the dynamic loaded part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say you are on page https://webpack.js.org/configuration/module/#modulegenerator, then you want to go another page's section, e.g.,
Clicking the side bar would load the new page, but it won't scroll to the section.
Not sure since when it's broken.