fix: add 'mode' property in second array object #5086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve issue in examples/general/config-array where absence of 'mode' property in second configuration object caused an error. Fixes webpack#5085
ayushkumarbhadani
requested review from
alexander-akait,
hiroppy,
snitin315 and
anshumanv
as code owners
The committers listed above are authorized under a signed CLA. |
alexander-akait
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue in examples/general/config-array where absence of 'mode' property in second configuration object caused an error.
Fixes #5085
For Bugs and Features; did you add new tests?
Not required
Motivation / Use-Case
I am new to Open Source and was testing the examples when I found that one of the examples (fixed in this PR) is not running and giving an error. I already have created an issue (#5085) for this PR.
Breaking Changes
No breaking changes.