Skip to content

fix: display file name in overlay #3867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2021
Merged

fix: display file name in overlay #3867

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef089e8
fix: display file name in overlay
githoniel Sep 22, 2021
609e98b
Merge branch 'master' into pr/overlay_filename
githoniel Sep 23, 2021
a3d5b61
fix: fix code error
githoniel Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions client-src/overlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,9 @@ function show(messages, type) {
messages.forEach((message) => {
const entryElement = document.createElement("div");
const typeElement = document.createElement("span");

typeElement.innerText = type === "warnings" ? "Warning:" : "Error:";
// ts-loader will output `error.file` for error file path, not in message
typeElement.innerText =
(type === "warnings" ? "Warning:" : "Error:") + (message.file || "");
typeElement.style.color = `#${colors.red}`;

// Make it look similar to our terminal.
Expand Down