-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update dependencies in V2 branch, fix compatibility with Node 10 #1715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your contribution. I don't think we still maintain the v2 branch. /cc @evilebottnawi |
@hiroppy some projects like ruby-rails stull use old version, we should fixes only compatibility/security issue when we release |
Oh, I did not know. OK, I'll review this pr. |
Hey, we also use v2 branch, so it would be great to have this fixes in next v2 versions. |
@ujenjt can you test this PR manually? |
Sure. I can test this PR with several projects which use |
@ujenjt nothing unusual just run and do what you usually do when developing |
Just tested |
@ujenjt Thank you for checking this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that this works at my local.
BTW, I wonder why Travis doesn't work.
Hey, thanks a lot for merging this to v2 branch. When we can expect this has been published to npm? |
@ujenjt ~24 hours |
For Bugs and Features; did you add new tests?
Updated travis.yml to test Node 10
Motivation / Use-Case
webpack-dev-server
2 depends on an older version ofspdy
which is not compatible with Node 10.See spdy-http2/handle-thing#5
I updated other dependencies with
npm audit fix
at the same time, it should fix a few vulnerabilities.Don't know if you still maintain the v2 branch.