Skip to content

Update dependencies in V2 branch, fix compatibility with Node 10 #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2019

Conversation

Volune
Copy link
Contributor

@Volune Volune commented Mar 12, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Updated travis.yml to test Node 10

Motivation / Use-Case

webpack-dev-server 2 depends on an older version of spdy which is not compatible with Node 10.
See spdy-http2/handle-thing#5

I updated other dependencies with npm audit fix at the same time, it should fix a few vulnerabilities.

Don't know if you still maintain the v2 branch.

@hiroppy
Copy link
Member

hiroppy commented Mar 12, 2019

Thank you for your contribution.

I don't think we still maintain the v2 branch. /cc @evilebottnawi

@alexander-akait
Copy link
Member

@hiroppy some projects like ruby-rails stull use old version, we should fixes only compatibility/security issue when we release v4 we official stop supporting v2 branch, so we can merge this and release as patch

@hiroppy
Copy link
Member

hiroppy commented Mar 12, 2019

Oh, I did not know. OK, I'll review this pr.

@ujenjt
Copy link

ujenjt commented Mar 18, 2019

Hey, we also use v2 branch, so it would be great to have this fixes in next v2 versions.

@alexander-akait
Copy link
Member

@ujenjt can you test this PR manually?

@ujenjt
Copy link

ujenjt commented Mar 18, 2019

@ujenjt can you test this PR manually?

Sure. I can test this PR with several projects which use webpack-dev-server v2 and check if it works. What kind of test do you want me to do? Any advice how to test better?

@alexander-akait
Copy link
Member

@ujenjt nothing unusual just run and do what you usually do when developing

@ujenjt
Copy link

ujenjt commented Mar 18, 2019

Just tested git://github.com/Volune/webpack-dev-server.git#v2-dependencies version with my webpack config - it works ok for me both with node v10.15.3 and v8.11.3.

@hiroppy
Copy link
Member

hiroppy commented Mar 20, 2019

@ujenjt Thank you for checking this!

@hiroppy hiroppy requested a review from alexander-akait March 20, 2019 21:31
Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this works at my local.
BTW, I wonder why Travis doesn't work.

@alexander-akait alexander-akait merged commit 2be7196 into webpack:v2 Mar 21, 2019
@ujenjt
Copy link

ujenjt commented Mar 21, 2019

Hey, thanks a lot for merging this to v2 branch. When we can expect this has been published to npm?

@alexander-akait
Copy link
Member

@ujenjt ~24 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants