[cli]: show help when invalid flag is supplied#1051
Conversation
|
Looks like this atm -
|
|
debugging |
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
I think we need to chill this until a fix for #1050 (fixing dupe args) is landed, because it will most likely impact this PR.
|
Sounds good even! |
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
Okay this could be resumed now, UNKNOWN_VALUE L41 in bootstrap needs modification
|
Will get back on this in a bit. 👍 |
|
We already have an unknown flag log when the flag is supplied, are there any other requirements/enhancements that we can do to it? @evenstensberg @ematipico |
|
Hi @anshumanv sorry to coming back to you so late, I completely missed this PR! About the message provided, could you print |
|
Hey Emanuale,
Def sounds better to be, will rebase and change it in a while 👍 |
handle invalid flags and show help in case invalid flag is supplied ISSUES CLOSED: webpack#1046
cleanup custom logic to determine invalid flags ISSUES CLOSED: webpack#1046
anshumanv
changed the title
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Thank you! |
5 participants
Fixes #1046
What kind of change does this PR introduce?
intercept flag parsing and if any invalid flag is present, print a neat err.
Did you add tests for your changes?
Will add
If relevant, did you update the documentation?
NA
Summary
Does this PR introduce a breaking change?
No
Other information