perf: prefer sass-embedded if available#1211
Merged
alexander-akait merged 1 commit intowebpack:masterfrom Jul 23, 2024
Merged
Conversation
6 tasks
G-Rath
force-pushed
the
prefer-sass-embedded
branch
2 times, most recently
from
58b967c to
1ddc100
Compare
G-Rath
force-pushed
the
prefer-sass-embedded
branch
from
1ddc100 to
78e1d9d
Compare
6 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1211 +/- ##
==========================================
- Coverage 94.44% 94.17% -0.27%
==========================================
Files 3 3
Lines 360 412 +52
Branches 132 155 +23
==========================================
+ Hits 340 388 +48
- Misses 18 22 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
The uncovered lines are not new, and don't seem to be easily covered as jest makes it a lot of work to mock |
alexander-akait
requested changes
Jul 23, 2024
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Sorry, we can't merge it right now, because it is a breaking change, I want t have a little bit more time to test sass-embedded in the wild, but I am fine with such changes
Member
|
Oh, looks like we need to do it due #1210, thank you |
alexander-akait
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
The Sass team considers
sass-embeddedto be stable and production-ready, so by preferring it oversassdevelopers can useoptionalDependenciesto take advantage of the more performant variant whenever possible without having to explicitly determine that for themselves.Resolves #1180
Resolves #1210
Breaking Changes
My understanding is that
sass-embeddedis a drop-in replacement, meaning this should not be a breaking change, though would appreciate input from @nex3 to confirm this is true enough to make this technically-not-breaking