docs(readme): clarify useable usage
#314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add missing information about what useable does
|
|
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 4 4
Lines 64 64
Branches 21 21
=======================================
Hits 63 63
Misses 1 1Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Apr 12, 2018
michael-ciniawsky
requested changes
May 5, 2018
README.md
Outdated
| @@ -88,6 +88,8 @@ import url from 'file.css' | |||
|
|
|||
| ### `Useable` | |||
|
|
|||
| Means that style-loader injects the style.use() style.unuse() | |||
There was a problem hiding this comment.
style-loader => `style-loader`
The style-loader injects the styles lazily making them useable on-demand via style.use()/style.unuse()
There was a problem hiding this comment.
updated in next commit
michael-ciniawsky
changed the title
useable usage
update after code review
michael-ciniawsky
changed the title
useable usageuseable usage
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 5 (nice to have)
severity: 5 (confusing)
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing information about what useable does
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the README?
Summary
Does this PR introduce a breaking change?
Other information