Skip to content

Conversation

arseniew
Copy link
Contributor

@arseniew arseniew commented Oct 6, 2017

What kind of change does this PR introduce?
documentation improvement

Did you add tests for your changes?
n/a

If relevant, did you update the README?
yes

Summary
Several configuration examples were missing commas in object syntax.
Form mine (and hopefully others) peace of mind

Does this PR introduce a breaking change?
no

Other information

@jsf-clabot
Copy link

jsf-clabot commented Oct 6, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please accept CLA

@arseniew
Copy link
Contributor Author

arseniew commented Oct 6, 2017

Hello, I have signed CLA now

@alexander-akait alexander-akait merged commit 57c457d into webpack-contrib:master Oct 6, 2017
@michael-ciniawsky michael-ciniawsky changed the title fixed missing commas in configuration examples docs(README): fixed missing commas in configuration examples Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants