Replace self:: with static:: in schema printer #1380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SchemaPrinter` class uses static methods. Those methods can be overloaded in a child class (they are protected). However, if we want the base `SchemaPrinter` static function to be able to call the overloaded functions in the child class, the call to these functions must be done using the `static::` keyword (Late static binding). This is done properly almost everywhere in the code, but in some places there remains calls done using `self::`. This commit turns the remaining `self::` into `static::` to make Late Static Binding possible.
moufmouf
added a commit
to moufmouf/graphqlite-laravel
that referenced
this pull request
May 9, 2023
In Webonyx, the getType() function can return null. In GraphQLite, it throws an error. This makes using the SchemaPrinter impossible. We override the SchemaPrinter to stop searching for the "Subscription" type. Note: this can only work if webonyx/graphql-php#1380 is merged.
moufmouf
added a commit
to moufmouf/graphqlite-laravel
that referenced
this pull request
May 9, 2023
In Webonyx, the getType() function can return null. In GraphQLite, it throws an error. This makes using the SchemaPrinter impossible. We override the SchemaPrinter to stop searching for the "Subscription" type. Note: this can only work if webonyx/graphql-php#1380 is merged.
spawnia
added a commit
that referenced
this pull request
May 9, 2023
|
Thanks, I documented this practice in 7d6b367. |
|
Woah! Thanks for the quick review. You rock ❤️ |
moufmouf
added a commit
to thecodingmachine/graphqlite-laravel
that referenced
this pull request
May 10, 2023
In Webonyx, the getType() function can return null. In GraphQLite, it throws an error. This makes using the SchemaPrinter impossible. We override the SchemaPrinter to stop searching for the "Subscription" type. Note: this can only work if webonyx/graphql-php#1380 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SchemaPrinterclass uses static methods.Those methods can be overloaded in a child class (they are protected). However, if we want the base
SchemaPrinterstatic function to be able to call the overloaded functions in the child class, the call to these functions must be done using thestatic::keyword (Late static binding).This is done properly almost everywhere in the code, but in some places there remains calls done using
self::.This commit turns the remaining
self::intostatic::to make Late Static Binding possible.