Skip to content

Conversation

edrichhans
Copy link
Contributor

@edrichhans edrichhans commented Mar 19, 2025

Hi @fredsted ! Closes #179

This PR makes sorting query param work, as documented in your website. I have also added tests.
I am not sure what I need to do in order to push this change into the docker hub image, so if the maintainer could help me with this after this is approved and merged, that would be great.

Thanks!

@edrichhans edrichhans changed the title feat: list request sorting fix: list request sorting Mar 19, 2025
Co-authored-by: Simon Fredsted <[email protected]>
@edrichhans
Copy link
Contributor Author

edrichhans commented Mar 20, 2025

Seems to be failing the unit test. Let me investigate

EDIT: Seems like the sortBy signature accepts a $descending boolean flag at the end to denote the order of sorting. The $options flag is not too descriptive, but it seems to denote how to sort instead of the order.

SCR-20250320-jhjq

In any case, my latest commit makes the unit pass again
image

@edrichhans edrichhans requested a review from fredsted March 20, 2025 02:09
@edrichhans
Copy link
Contributor Author

Hi @fredsted , can I follow up on getting this merged and released when you have the time? 😄 Thanks!

@fredsted fredsted merged commit 1833c75 into webhooksite:master Apr 4, 2025
@fredsted
Copy link
Collaborator

fredsted commented Apr 4, 2025

Tested, seems to be working.

@edrichhans
Copy link
Contributor Author

Thanks @fredsted . Can I know what is your release schedule for the docker image?

@fredsted
Copy link
Collaborator

fredsted commented Apr 8, 2025

Docker image is already released. https://hub.docker.com/r/webhooksite/webhook.site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET /token/:id/requests does not have sorting option
2 participants