This repository was archived by the owner on Mar 5, 2025. It is now read-only.
pickup latest fsevents (v1.2.9) for Node 12 compat #2951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsevents is a transitive dependency by way of jest. `package-lock.json` was doing its job and preventing a bump to fsevents v1.2.9, i.e. even though the caret ranges for that dependency would allow for it. Older versions of `fsevents` are not compatible with Node.js 12, so for this commit `package-lock.json` was manually bumped (resolved fsevents was removed from the file and then `npm install` was rerun).
1 similar comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsevents is a transitive dependency by way of jest.
package-lock.jsonwas doing its job and preventing a bump to fsevents v1.2.9, i.e. even though the caret ranges for that dependency would allow for it.Older versions of
fseventsare not compatible with Node.js 12, so for this commitpackage-lock.jsonwas manually bumped (resolved fsevents was removed from the file and thennpm installwas rerun).