Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Length check and formatting private key in accounts.privateKeyToAccount method #2929

Merged
merged 10 commits into from
Jul 15, 2019
Merged

Length check and formatting private key in accounts.privateKeyToAccount method #2929

merged 10 commits into from
Jul 15, 2019

Conversation

chirag-parmar
Copy link

Fixes #2928

nivida
nivida suggested changes Jul 8, 2019
View reviewed changes
@nivida nivida added 2.x 2.0 related issues Enhancement Includes improvements or optimizations In Progress Currently being worked on labels Jul 8, 2019
@coveralls
Copy link

coveralls commented Jul 14, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 95.535% when pulling 183fd68 on chirag-parmar:2.x into 9136975 on ethereum:2.x.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 95.568% when pulling c6caffc on chirag-parmar:2.x into 8ed2fbc on ethereum:2.x.

@nivida nivida removed the In Progress Currently being worked on label Jul 15, 2019
@nivida nivida merged commit f2ac320 into web3:2.x Jul 15, 2019
@lekkas lekkas mentioned this pull request Sep 2, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nivida nivida nivida requested changes

Assignees
No one assigned
Labels
2.x 2.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No bounds on key length in method privateKeyToAccount()
3 participants
@chirag-parmar @coveralls @nivida