Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fix Subscription Type #2919

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Fix Subscription Type #2919

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b7287c
return self on subscrption.on method
JunichiSugiura Jun 30, 2019
20c54f0
Merge branch '2.x' into hotfix/subscription-type
nivida Jul 8, 2019
c61443a
Merge branch '2.x' into hotfix/subscription-type
nivida Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/web3-eth/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,11 +216,11 @@ export interface Subscription<T> {

unsubscribe(callback?: (error: Error, result: boolean) => void): Promise<undefined | boolean>;

on(type: 'data', handler: (data: T) => void): void
on(type: 'data', handler: (data: T) => void): Subscription<T>

on(type: 'changed', handler: (data: T) => void): void
on(type: 'changed', handler: (data: T) => void): Subscription<T>

on(type: 'error', handler: (data: Error) => void): void
on(type: 'error', handler: (data: Error) => void): Subscription<T>
}

export interface GetProof {
Expand Down