Node 12 support

[ellis2323]

web3.js uses web3-eth-accounts which uses scrypt.js which uses scrypt. Scrypt is not maintained anymore and is incompatible with node 12. I've contacted scrypt.js but i'm not sure this package is well maintained. a pull request is available on scrypt.js to fix the problem.

barrysteyn/node-scrypt#193

[nivida]

Thanks for opening this issue! We have already discussed this issue and @alcuadrado opened the PR's for the scrypt.js package. The goal would be to have this fix included in the next release.

[SebastianGiro]

#2903

@ellis2323 @nivida

[levino]

Why not remove the package altogether and use something else?

[nivida]

There are several ways to solve it:

1. Moving of the logic from the scrypt.js package to Web3.js to fix and improve it.
2. Alex (axic) the maintainer and part of the Ethereum Foundation can handover us the ownership and we will update the package. (Which would be good because it's used in many other ethereum JS related packages and projects which are depending on these modules)
3. Usage of the scrypt.js logic and publishing of a new package with a future proof fix
4. Checking if there are alternative packages with the same outcome.

The fix for this issue will be released with 1.0.1 and 2.0-alpha.1

[levino]

The fix for this issue will be released with 1.0.1 and 2.0-alpha.1

Really? Why? This is the most important thing for web3? I think it is okay not to support node 12 for the time being...

[SebastianGiro]

@levino angular 8 depends on node 12. And is one of the most used frameworks out there.

[levino]

Angular apps run in the browser, so not in node. Maybe the angular build tools depend on node 12 but then just use the minified browser version of web3 for your project and you should be fine...

[joshstevens19]

Just to correct that statement here, current web3 can run on angular 8 fine using the standard NPM install and not the minified browser version we have it all working with no problems.

Angular for all versions including 8 only recommends the latest stable node release it does work and supports node 10 and will even run on node 8.

If angular forced something like that it would be so much disruption for companies that would then need to upgrade all of their build servers with Node 12 before thinking about creating an Angular 8 project.

@SebastianGiro

[levino]

For the record: I agree that this is an issue and that support for node 12 must be established rather sooner than later. I was merely saying that there are workarounds and imo nobody needs to be blocked by this atm.

Angular for all versions including 8 only recommends the latest stable node release it does work and supports node 10 and will even run on node 8.

That's correct.

If angular forced something like that it would be so much disruption for companies that would then need to upgrade all of their build servers with Node 12 before thinking about creating an Angular 8 project.

Please be reasonable. "Angular is wrong to require node 12" is surely not an argument.

[joshstevens19]

@levino angular does not require node 12! it recommends the latest version of node and runs perfectly fine on older versions, we should stop using the word require which can confuse a lot of people here. My statement was a fact in what angular actually pride themselves on not forcing people to have to change their build servers and easy upgrades. Moral of the story angular 8 does not need or require node 12 to work, so it should not be a point in this issue and i was merely just correcting the statements above to avoid huge confusion.

[levino]

I agree with you. How about you carefully read my statements first.