Fix pointerevent_after_target_removed_from_slot.html asserts #55894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL updates the test its and expectations to match the event hittest behavior in practice after either the slot or the element placed in the slot is removed. To avoid boundary event complications caused by layout changes, all relevant elements are made same sized. The expectations are written based on the following observations: each test starts with `host` containing the shadow-root containing `parent` containing `slot` in which `child` is placed; `child` remains hidden as a a sibling of the shadow-root until placed in `slot`. - Removing `slot` returns `child` back to the hidden position. - Removing `child` exposes the subtree of `slot`. Manual testing: https://codepen.io/mustaqahmed/full/LEGgpMQ Bug: 404479707 Change-Id: I2ce50112f7f1bdb2a4cb6417e7477f59be5e1b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7107458 Reviewed-by: Robert Flack <[email protected]> Commit-Queue: Mustaq Ahmed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541198}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7107458
branch
from
f8ac4ac to
157f3c7
Compare
wpt-pr-bot
approved these changes
Nov 6, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
mishtiagrawal02-cloud
pushed a commit
to mishtiagrawal02-cloud/wpt
that referenced
this pull request
Dec 27, 2025
…-tests#56614 This PR adds 13 comprehensive documentation files (~40k words) that explain the resolution to GitHub issue web-platform-tests#56614: 'Expectations in pointerevent_after_target_removed_from_slot.html' ## Documentation Includes: **Quick Start Guides:** - 00_START_HERE.md: Master summary and navigation - QUICK_COMMANDS.md: Copy-paste terminal commands for PR submission - QUICK_REFERENCE.md: Q&A, troubleshooting, and quick lookup **Comprehensive Learning:** - POINTER_EVENTS_FIX_SUMMARY.md: Technical overview of the fix - DETAILED_ANALYSIS.md: In-depth analysis of the problem - COMPLETE_SOLUTION.md: Full explanation of all aspects - SOLUTION_COMPLETE.md: Complete solution overview **Contributing & Guidance:** - HOW_TO_CREATE_PR.md: Step-by-step PR creation guide - PULL_REQUEST_GUIDE.md: Contributing patterns to WPT - GITHUB_ISSUE_GUIDE.md: How to file and reference issues - PR_SUBMISSION_GUIDE.md: Complete PR submission workflow - README_DOCUMENTATION.md: Documentation index and navigation - INDEX_AND_SUMMARY.md: Quick reference index ## What This Explains: ✅ The original issue with pointer events in shadow DOM ✅ Why tests were failing in all browsers ✅ How the fix aligns with W3C specifications ✅ Three test scenarios: remove-slot, remove-filler, change-slotname ✅ Event retargeting and boundary event behavior ✅ Privacy implications of relatedTarget ✅ How to understand and extend these concepts ✅ Step-by-step guides for contributors ## Related Issues: - Fixes web-platform-tests#56614 - References commit a9f4351 (the actual fix) - PR web-platform-tests#55894 (original PR that fixed the issue) ## For Reviewers: These docs are reference material to help: - New contributors understand pointer events - Developers debug similar shadow DOM issues - Teams understand spec-compliant event dispatch - Future maintainers understand the fix rationale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL updates the test its and expectations to match the event hittest
behavior in practice after either the slot or the element placed in the
slot is removed. To avoid boundary event complications caused by layout
changes, all relevant elements are made same sized.
The expectations are written based on the following observations: each
test starts with
hostcontaining the shadow-root containingparentcontaining
slotin whichchildis placed;childremains hidden asa a sibling of the shadow-root until placed in
slot.slotreturnschildback to the hidden position.childexposes the subtree ofslot.Manual testing: https://codepen.io/mustaqahmed/full/LEGgpMQ
Bug: 404479707
Change-Id: I2ce50112f7f1bdb2a4cb6417e7477f59be5e1b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7107458
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1541198}