-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Don't decode arbitrary %2e during URL parsing after all #4104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewers for this pull request are: @Sebmaster, @domenic, @frewsxcv, @mikewest, @rubys, @sideshowbarker, @smola, @tomalec, @xiaojunwu, and @zcorpan. |
Note that Firefox already WONTFIXED their corresponding bug (and therefore agrees with this change) and Safari advocated for it. We don't really know what the other browsers will do unfortunately. |
I suggest we keep this open for now given that Google is not okay with going in this direction. |
This reverts commit 47d2089. See whatwg/url#87 for discussion.
This reverts commit 47d2089. See whatwg/url#87 for discussion.
2e64b13
to
d179f7e
Compare
I suggest we land this per whatwg/url#87 (comment) since what's currently defined isn't really implemented anywhere. |
This basically reverts bee5ad8 as it did not end up shipping in Firefox and the tentative conclusion is that percent-decoding in URLs while parsing creates more trouble than it’s worth. We’ll still handle %2e when it’s part of a single-dot or double-dot path segment. Tests: web-platform-tests/wpt#4104. Closes #87.
After updating whatwg-url per https://github.com/whatwg/url/pull/156/files the following tests additionally fail:
|
This basically reverts bee5ad8 as it did not end up shipping in Firefox and the tentative conclusion is that percent-decoding in URLs while parsing creates more trouble than it’s worth. We’ll still handle %2e when it’s part of a single-dot or double-dot path segment. Tests: web-platform-tests/wpt#4104. Closes #87.
This reverts commit 47d2089.
See whatwg/url#87 for discussion.
This change is