Fetch: add tests for Response.json #32825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domfarolino,
jdm,
mnot,
youennf and
yutakahirano
3 tasks
KhafraDev
reviewed
Feb 17, 2022
KhafraDev
reviewed
Mar 9, 2022
annevk
approved these changes
Mar 11, 2022
yutakahirano
approved these changes
Mar 22, 2022
ricea
reviewed
May 11, 2022
|
@ricea Added. |
|
I'd like to land these tests so I can ship this feature in Deno in our canary branch. Any objections? Should I mark them "tenative" until the spec PR lands? |
|
Yes, fine to land as "tentative" if you're willing to rename them later. |
ricea
approved these changes
May 12, 2022
lucacasonato
force-pushed
the
response_json_static_method
branch
from
33c3c7f to
1a8281d
Compare
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
May 18, 2022
A method that can be used to create well-formed JSON responses with very little effort. The JSON response is not pretty printed. Tests: web-platform-tests/wpt#32825. Closes #1389.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 30, 2022
This commit adds support for the `Response.json` static method as specified in whatwg/fetch#1392. All WPTs from web-platform-tests/wpt#32825 pass. Bug: 1305358 Change-Id: Iaafdd514ed12644b6433c02e7d076ce43f51b9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3639064 Reviewed-by: Yutaka Hirano <[email protected]> Reviewed-by: Adam Rice <[email protected]> Commit-Queue: Yutaka Hirano <[email protected]> Cr-Commit-Position: refs/heads/main@{#1019479}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec change: whatwg/fetch#1392