font-width: Add @font-face descriptor to feature#3800
font-width: Add @font-face descriptor to feature#3800ddbeck merged 2 commits intoweb-platform-dx:mainfrom
font-width: Add @font-face descriptor to feature#3800Conversation
ddbeck
added
the
feature definition
| compute_from: | ||
| - css.properties.font-width | ||
| - css.properties.font-width.condensed | ||
| - css.properties.font-width.expanded | ||
| - css.properties.font-width.extra-condensed | ||
| - css.properties.font-width.extra-expanded | ||
| - css.properties.font-width.normal | ||
| - css.properties.font-width.semi-condensed | ||
| - css.properties.font-width.semi-expanded | ||
| - css.properties.font-width.ultra-condensed | ||
| - css.properties.font-width.ultra-expanded | ||
| - css.at-rules.font-face.font-width |
There was a problem hiding this comment.
Wouldn't it make our life easier if we also had a ignore_keys field?
This feature basically uses a compute_from for all keys but one, and it would be great if instead we could ignore that one only, with a comment.
Maybe file an issue to think about this? If you think this would be useful.
There was a problem hiding this comment.
I think we'll need a more sophisticated answer for this to deal with feature merges, so the aspects "issue" is kinda representing this problem already (i.e., we'll name groups of keys to make the initial/later/related distinctions explicit and make it easier to move them around semi-automatically).
I can make a separate issue if you like, though.
| - css.properties.font-width.ultra-expanded | ||
| - css.at-rules.font-face.font-width | ||
| compat_features: | ||
| - api.CSSFontFaceDescriptors.fontWidth |
There was a problem hiding this comment.
Can you please add a comment for this key? Something like:
"This key is excluded from the Baseline calculation using compute_from, above, because it shipped a little later than the rest of the keys in Safari, and it isn't worth delaying the feature for, etc...."
| compute_from: | ||
| - css.properties.font-width | ||
| - css.properties.font-width.condensed | ||
| - css.properties.font-width.expanded | ||
| - css.properties.font-width.extra-condensed | ||
| - css.properties.font-width.extra-expanded | ||
| - css.properties.font-width.normal | ||
| - css.properties.font-width.semi-condensed | ||
| - css.properties.font-width.semi-expanded | ||
| - css.properties.font-width.ultra-condensed | ||
| - css.properties.font-width.ultra-expanded | ||
| - css.at-rules.font-face.font-width |
There was a problem hiding this comment.
I think we'll need a more sophisticated answer for this to deal with feature merges, so the aspects "issue" is kinda representing this problem already (i.e., we'll name groups of keys to make the initial/later/related distinctions explicit and make it easier to move them around semi-automatically).
I can make a separate issue if you like, though.
| description: The `font-width` CSS property selects a font face from a font family based on width, either by a keyword such as `condensed` or a percentage. | ||
| spec: https://drafts.csswg.org/css-fonts-4/#font-width-prop | ||
| group: fonts | ||
| status: |
|
Vào Thứ 7, 7 thg 3, 2026 lúc 19:02 Ngô Trang ***@***.***> đã
viết:
… ***@***.**** commented on this pull request.
------------------------------
In features/font-width.yml
<#3800 (comment)>
:
> @@ -2,7 +2,21 @@ name: font-width
description: The `font-width` CSS property selects a font face from a font family based on width, either by a keyword such as `condensed` or a percentage.
spec: https://drafts.csswg.org/css-fonts-4/#font-width-prop
group: fonts
+status:
features/font-width.yml
—
Reply to this email directly, view it on GitHub
<#3800 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARAM5NFHVX7R7GFNGI2HGFL4PQFUFAVCNFSM6AAAAACV4QABP6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSMBYGY2TAOBSGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
3 participants
Fixes #3795