Replace many uses of the word "interface" #3256
Open
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most places API is more natural and consistent with the rest of web-features. Sanitizer is aligned with the wording in parse-html-unsafe.yml. For WebDriver "interface" isn't wrong, but protocol seems clearer.
github-actions
bot
added
the
feature definition
ddbeck
approved these changes
Aug 26, 2025
| @@ -1,5 +1,5 @@ | |||
| name: DOM Geometry | |||
| description: The `DOMMatrix`, `DOMPoint`, `DOMQuad` and `DOMRect` interfaces offer a way to represent points, rectangles, quadrilaterals and transformation matrices within JavaScript. They can be used in transformations in CSS, `<canvas>`, and SVG. | |||
| description: The `DOMMatrix`, `DOMPoint`, `DOMQuad` and `DOMRect` APIs offer a way to represent points, rectangles, quadrilaterals and transformation matrices within JavaScript. They can be used in transformations in CSS, `<canvas>`, and SVG. | |||
There was a problem hiding this comment.
Suggested change
| description: The `DOMMatrix`, `DOMPoint`, `DOMQuad` and `DOMRect` APIs offer a way to represent points, rectangles, quadrilaterals and transformation matrices within JavaScript. They can be used in transformations in CSS, `<canvas>`, and SVG. | |
| description: The `DOMMatrix`, `DOMPoint`, `DOMQuad` and `DOMRect` APIs represent points, rectangles, quadrilaterals and transformation matrices within JavaScript. They can be used in transformations in CSS, `<canvas>`, and SVG. |
| @@ -1,5 +1,5 @@ | |||
| name: Sanitizer API | |||
| description: The `parseHTML()` method for the `Document` interface and the `setHTML()` methods for the `Element` and `ShadowRoot` interfaces parse and insert HTML into the DOM in a way that can prevent cross-site scripting attacks. The `Sanitizer` API can customize the sanitization process. | |||
| description: The `Document.parseHTML()` static method and the `setHTML()` method of `Element` and `ShadowRoot` parses and insert HTML into the DOM in a way that can prevent cross-site scripting attacks. The `Sanitizer` API can customize the sanitization process. | |||
There was a problem hiding this comment.
Something about this read a little off to me. In contrast to Document, a developer is unlikely to actually touch the Element and ShadowRoot interfaces directly, but manipulate instances. What do you think of this change?
Suggested change
| description: The `Document.parseHTML()` static method and the `setHTML()` method of `Element` and `ShadowRoot` parses and insert HTML into the DOM in a way that can prevent cross-site scripting attacks. The `Sanitizer` API can customize the sanitization process. | |
| description: The `Document.parseHTML()` static method and the `setHTML()` method of `Element` and `ShadowRoot` objects parse and insert HTML into the DOM in a way that can prevent cross-site scripting attacks. The `Sanitizer` API can customize the sanitization process. |
|
Approved, but with a couple of suggestions. Merge at your discretion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most places API is more natural and consistent with the rest of
web-features.
Sanitizer is aligned with the wording in parse-html-unsafe.yml.
For WebDriver "interface" isn't wrong, but protocol seems clearer.