Skip to content

Add shared-storage-locks #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Feb 11, 2025

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Feb 11, 2025
Copy link
Collaborator

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddbeck ddbeck marked this pull request as draft February 27, 2025 11:04
@ddbeck ddbeck changed the title shared-storage: assign more keys Add shared-storage-locks Feb 27, 2025
@ddbeck
Copy link
Collaborator Author

ddbeck commented Feb 27, 2025

The alternative here would be to make a new feature "Web Locks integration with Shared Storage" https://chromestatus.com/feature/5133950203461632 https://github.com/WICG/shared-storage?tab=readme-ov-file#locking-for-modifier-methods

@Elchi3 thank you! I wasn't aware of this. I've retooled this PR as adding shared-storage-locks. I noted in a comment that there's potentially missing keys in BCD, depending on how thorough you wish to be there. I also updated the PR description with some additional explanatory links. This was a little hard to get my head around. 😅

@ddbeck ddbeck marked this pull request as ready for review February 27, 2025 11:38
@Elchi3 Elchi3 merged commit e2dbe5d into web-platform-dx:main Feb 27, 2025
3 checks passed
@ddbeck ddbeck deleted the shared-storage-more-keys branch February 27, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants