Split custom elements into two features #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
foolip
commented
May 15, 2024
foolip
commented
May 15, 2024
ddbeck
reviewed
May 15, 2024
Co-authored-by: Daniel D. Beck <[email protected]>
I did consider that, but I hesitated because maybe we'll want a composite feature later to match the caniuse feature. But let me add the group and deal with that problem if it appears later. Some of the CSS pseudo-classes that aren't part of either feature now should probably go in the same group. |
ddbeck
approved these changes
May 15, 2024
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
May 16, 2024
This should match web-platform-dx/web-features#1089.
This was referenced May 16, 2024
foolip
added a commit
to foolip/wpt
that referenced
this pull request
May 16, 2024
This should match web-platform-dx/web-features#1089. The test results on wpt.fyi were used as a guide for where there might be tests involving customized built-in elements, and all tests with failures were given a quick review before deciding where to map it. Mistakes are still possible. This is the most complicated mapping to web-features so far, and shows some limitations of the WEB_FEATURES.yml format. This could be simplified with exclusion patterns in the format, but would still not be simple. Two files were renamed in the process of preparing this: web-platform-tests#46305 web-platform-tests#46306
|
The WPT side of this is done in web-platform-tests/wpt#46309 and was quite hairy. |
ddbeck
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
May 16, 2024
foolip
added a commit
to foolip/wpt
that referenced
this pull request
May 17, 2024
This should match web-platform-dx/web-features#1089. The test results on wpt.fyi were used as a guide for where there might be tests involving customized built-in elements, and all tests with failures were given a quick review before deciding where to map it. Mistakes are still possible. This is the most complicated mapping to web-features so far, and shows some limitations of the WEB_FEATURES.yml format. This could be simplified with exclusion patterns in the format, but would still not be simple. Two files were renamed in the process of preparing this: web-platform-tests#46305 web-platform-tests#46306
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 21, 2024
This should match web-platform-dx/web-features#1089. The test results on wpt.fyi were used as a guide for where there might be tests involving customized built-in elements, and all tests with failures were given a quick review before deciding where to map it. Mistakes are still possible. This is the most complicated mapping to web-features so far, and shows some limitations of the WEB_FEATURES.yml format. This could be simplified with exclusion patterns in the format, but would still not be simple. Two files were renamed in the process of preparing this: #46305 #46306
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 30, 2024
…tures, a=testonly Automatic update from web-platform-tests Map custom elements to two different features (#46309) This should match web-platform-dx/web-features#1089. The test results on wpt.fyi were used as a guide for where there might be tests involving customized built-in elements, and all tests with failures were given a quick review before deciding where to map it. Mistakes are still possible. This is the most complicated mapping to web-features so far, and shows some limitations of the WEB_FEATURES.yml format. This could be simplified with exclusion patterns in the format, but would still not be simple. Two files were renamed in the process of preparing this: web-platform-tests/wpt#46305 web-platform-tests/wpt#46306 -- wpt-commits: d437c3d7a1bc22ac2cd0cc902ff5d891ae448e2d wpt-pr: 46309
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
May 31, 2024
…tures, a=testonly Automatic update from web-platform-tests Map custom elements to two different features (#46309) This should match web-platform-dx/web-features#1089. The test results on wpt.fyi were used as a guide for where there might be tests involving customized built-in elements, and all tests with failures were given a quick review before deciding where to map it. Mistakes are still possible. This is the most complicated mapping to web-features so far, and shows some limitations of the WEB_FEATURES.yml format. This could be simplified with exclusion patterns in the format, but would still not be simple. Two files were renamed in the process of preparing this: web-platform-tests/wpt#46305 web-platform-tests/wpt#46306 -- wpt-commits: d437c3d7a1bc22ac2cd0cc902ff5d891ae448e2d wpt-pr: 46309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1088.