Skip to content

fix(config): tighten rule loader/use typings#13514

Open
kyungilcho wants to merge 1 commit intoweb-infra-dev:mainfrom
kyungilcho:codex/fix-rule-loader-types
Open

fix(config): tighten rule loader/use typings#13514
kyungilcho wants to merge 1 commit intoweb-infra-dev:mainfrom
kyungilcho:codex/fix-rule-loader-types

Conversation

@kyungilcho
Copy link
Copy Markdown

Summary

Tightens the RuleSetRule typing around loader, use, and top-level options so invalid shorthand combinations are rejected at type-check time.

It also stops mutating rule.use in the adapter and adds a type regression test to lock the behavior in.

Related links

Closes #10278

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@kyungilcho kyungilcho requested a review from hardfist as a code owner March 29, 2026 13:41
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 29, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 30, 2026

Merging this PR will not alter performance

🎉 Hooray! codspeed-node just leveled up to 5.2.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

✅ 9 untouched benchmarks
⏩ 25 skipped benchmarks1


Comparing kyungilcho:codex/fix-rule-loader-types (3220af0) with main (155a73e)

Open in CodSpeed

Footnotes

  1. 25 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@chenjiahan chenjiahan requested a review from LingyuCoder March 30, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: More precise type definition for Rule.use and Rule.loader

1 participant