feat(eslint-plugin-jest): add no-focused-tests rule#577
Open
eryue0220 wants to merge 17 commits intoweb-infra-dev:mainfrom
Open
feat(eslint-plugin-jest): add no-focused-tests rule#577eryue0220 wants to merge 17 commits intoweb-infra-dev:mainfrom
no-focused-tests rule#577eryue0220 wants to merge 17 commits intoweb-infra-dev:mainfrom
Conversation
…ribe_callback.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…st-no-disabled-tests
…lint-plugin-jest-no-focused-tests
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a Jest plugin for the linter, implementing rules such as no-disabled-tests, no-focused-tests, no-hooks, and valid-describe-callback. The implementation includes AST utilities for parsing Jest function calls and a TypeScript-based testing framework. Feedback indicates that the endColumn in no-focused-tests test cases is incorrect for aliased functions, as it should only target the specific character being modified. Additionally, the settings field in the test runner is currently not passed to the linting function, which limits the ability to test configurations like global aliases.
packages/rslint-test-tools/tests/eslint-plugin-jest/rules/no-focused-tests.test.ts
Show resolved
Hide resolved
packages/rslint-test-tools/tests/eslint-plugin-jest/rules/no-focused-tests.test.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port no-focused-tests from eslint-plugin-jest to rslint.
Related Links
Tracking issue: #476
eslint-plugin-jest/no-focused-tests doc code
Checklist
Others
This pr is based on #572 as well