Skip to content

docs: clarify execution order with modifyHTML and html.tags #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025

Conversation

chenjiahan
Copy link
Member

Summary

Added a tip explaining the execution order when using modifyHTML, modifyHTMLTags, and html.tags options together.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings July 3, 2025 04:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the plugin hook docs to clarify the execution sequence when using modifyHTML, modifyHTMLTags, and html.tags together by removing an incorrect ordering note and adding an execution-order tip.

  • Removed the outdated “before modifyHTML” note from the modifyHTMLTags section.
  • Added a tip that lists the precise order of modifyHTML, modifyHTMLTags, and html.tags.
  • Updated both English and Chinese docs accordingly.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
website/docs/zh/plugins/dev/hooks.mdx Removed incorrect ordering note; added a Chinese tip for execution order
website/docs/en/plugins/dev/hooks.mdx Removed incorrect ordering note; added an English tip for execution order
Comments suppressed due to low confidence (1)

website/docs/zh/plugins/dev/hooks.mdx:622

  • 链接路径应指向中文版本文档,例如 /zh/config/html/tags,以保持与当前语言文档的一致性。
3. [html.tags](/config/html/tags)

Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 1bfb5ff
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/686601ccfa97fb000833bc81
😎 Deploy Preview https://deploy-preview-5523--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@chenjiahan chenjiahan merged commit fa6e36d into main Jul 3, 2025
12 checks passed
@chenjiahan chenjiahan deleted the hook_order_doc_0703 branch July 3, 2025 04:10
@chenjiahan chenjiahan mentioned this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant