Skip to content

gh-43: Fix ESModule incompatibility with node16 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

gh-43: Fix ESModule incompatibility with node16 #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 .eslintrc.js → .eslintrc.cjs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion build.js → build.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ esbuild
bundle: true,
entryPoints: ['./src/index.ts'],
external: ['@babel/runtime', 'isomorphic-fetch', 'graphql-request'],
format: 'cjs',
format: 'esm',
logLevel: 'info',
metafile: true,
minify: true,
Expand Down
0 jest.config.js → jest.config.cjs
View file
Open in desktop
File renamed without changes.
13 changes: 7 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,24 @@
"version": "1.1.0",
"description": "TypeScript client for Weaviate",
"main": "dist/index.js",
"types": "types/index.d.ts",
"types": "dist/index.d.ts",
"type": "module",
"engines": {
"node": ">=16.0.0"
},
"files": [
"/dist/index.js",
"/dist/index.js.map",
"/types/**/*.d.ts"
"/dist/**/*.d.ts"
],
"scripts": {
"test": "tsc -noEmit -p tsconfig-test.json && jest --useStderr --runInBand --detectOpenHandles",
"build": "npm run lint && tsc --emitDeclarationOnly && ./build.js",
"build": "npm run lint && tsc --emitDeclarationOnly && ./build.cjs",
"prepack": "npm run build",
"lint": "eslint --ext .ts,.js .",
"lint": "eslint --ext .ts,.js,.cjs .",
"lint:fix": "npm run lint -- --fix",
"format": "prettier --write --no-error-on-unmatched-pattern '**/*.{ts,js}' '!dist/**' '!types/**'",
"format:check": "prettier --check --no-error-on-unmatched-pattern '**/*.{ts,js}' '!dist/**' '!types/**'",
"format": "prettier --write --no-error-on-unmatched-pattern '**/*.{ts,js,cjs}' '!dist/**' '!types/**'",
"format:check": "prettier --check --no-error-on-unmatched-pattern '**/*.{ts,js,cjs}' '!dist/**' '!types/**'",
"prepare": "husky install"
},
"repository": {
Expand Down
3 changes: 1 addition & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ function initDbVersionProvider(conn: Connection) {
return dbVersionProvider;
}

module.exports = app;
export default app;
export * from './openapi/types';
export * from './graphql';
export * from './schema';
Expand All @@ -105,3 +103,4 @@ export * from './c11y';
export * from './backup';
export * from './cluster';
export * from './connection';
export default app;
5 changes: 2 additions & 3 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,15 @@
"allowJs": true,
"checkJs": false,
"sourceMap": false,
"module": "commonjs",
"module": "ES2020",
"moduleResolution": "node",
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"isolatedModules": true,
"outDir": "./types",
"outDir": "./dist",
"declaration": true,
"rootDir": "./src",
"types": ["node"]
},
"include": ["./src/**/*"],
"exclude": ["**/*.test.ts"]
Expand Down