Add support for statistic field in CloudwatchMetricsTarget#543
Add support for statistic field in CloudwatchMetricsTarget#543JamesGibo merged 2 commits intoweaveworks:mainfrom
statistic field in CloudwatchMetricsTarget#543Conversation
JamesGibo
left a comment
There was a problem hiding this comment.
Thanks for this PR, I do not use cloudwatch so will have to trust that this is required, but as this is not a breaking change I am happy to add it.
Please could you add a little description of what the difference is between the 2 fields to the doc strings?
|
Honestly I'm not able to answer your (legitimate) questions, since I could not find any documentation about it. I was trying to create a dashboard that uses CloudWatch for some panels and through some reverse engineering I found that setting the field "statistics" did not produce any effect (the query is considered wrong), calling it "statistic" and changing it's type from list to string, instead, works fine. I've just added a new field instead of replacing the existing one, since "statistics" seems to have a meaning at some points (https://grafana.com/docs/grafana/latest/datasources/aws-cloudwatch/template-queries-cloudwatch/#query-variable); and I've added it just to v9 because I've tested it with this version. |
What does this do?
Add support for
statisticfield inCloudwatchMetricsTargetWhy is it a good idea?
The existing
statisticsfield is being ignored by grafana 9.x, it must be namedstatistic(notstatistics) and must be a string (not a list)